feature: add XPNFTToken with MetadataGenerator #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityblast
changed the title
gravityblast
force-pushed
the
xp-nft-token-renderer
branch
from
e1431a6
to
84a547d
Compare
0x-r4bbit
approved these changes
Oct 10, 2024
| function balanceOf(address account) external view returns (uint256); | ||
| } | ||
|
|
||
| contract XPNFTToken is Ownable { |
There was a problem hiding this comment.
Just a nitpick: shall we make this Ownable2step?
| } | ||
|
|
||
| function mint() external { | ||
| emit Transfer(msg.sender, msg.sender, uint256(uint160(msg.sender))); |
There was a problem hiding this comment.
Can you elaborate on why we're doing it this way again?
There was a problem hiding this comment.
Ah I see, so an account's address is essentially the ID for the token.
This means every account automatically "owns" this NFT with most of them having 0 XP
| function tokenURI(uint256 tokenId) external view onlyValidTokenId(tokenId) returns (string memory) { | ||
| address account = address(uint160(tokenId)); | ||
| uint256 balance = xpToken.balanceOf(account); | ||
| return metadataGenerator.generate(account, balance); |
|
This is not passing the linter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base PoC of the XP NFT Token with dynamic on-chain metadata with info from the XP Token
output of the
tokenUrifunction:with
SVG_BASE64_ENCODEDas the base64 of:that renders like the following image:
closes #37